xiarixiaoyao commented on a change in pull request #4962:
URL: https://github.com/apache/hudi/pull/4962#discussion_r834916352
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java
##########
@@ -91,6 +92,8 @@ public BaseCommitActionExecutor(HoodieEngineContext context,
HoodieWriteConfig c
// TODO : Remove this once we refactor and move out autoCommit method from
here, since the TxnManager is held in {@link BaseHoodieWriteClient}.
this.txnManager = new TransactionManager(config,
table.getMetaClient().getFs());
this.lastCompletedTxn =
TransactionUtils.getLastCompletedTxnInstantAndMetadata(table.getMetaClient());
+ this.pendingRequestedInstants =
TransactionUtils.getInflightInstants(table.getMetaClient());
Review comment:
@suryaprasanna @yihua thanks for your remiding, i think it's no
problem,
the pendingInstants BaseCommitActionExecutor is used for autoCommit,
1) pendingRequestedInstants is worked together with lastCompletedTxn.
2) in BaseCommitActionExecutor we update lastCompletedTxnand
pendingRequestedInstants together.
in autoCommit fuction, we used updated lastCompletedTxn and
pendingRequestedInstants.
when we check conflict in resolveWriteConflictIfAny, we combine the
pending Instants and
SimpleConcurrentFileWritesConflictResolutionStrategy.getCandidateInstants
together to check conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
