xushiyan commented on a change in pull request #5082:
URL: https://github.com/apache/hudi/pull/5082#discussion_r834983435
##########
File path: .github/workflows/bot.yml
##########
@@ -38,6 +64,11 @@ jobs:
architecture: x64
- name: Build Project
env:
- SCALA_PROFILE: ${{ matrix.scala }}
- SPARK_PROFILE: ${{ matrix.spark }}
- run: mvn install -P "$SCALA_PROFILE,$SPARK_PROFILE" -DskipTests=true
-Dmaven.javadoc.skip=true -B -V
+ SCALA_PROFILE: ${{ matrix.scalaProfile }}
+ SPARK_PROFILE: ${{ matrix.sparkProfile }}
+ SPARK_VERSION: ${{ matrix.sparkVersion }}
+ SCALA_BINARY_VERSION: ${{ matrix.scalaBinaryVersion }}
+ run: |
+ mvn install -P "$SCALA_PROFILE,$SPARK_PROFILE"
-Dspark.version="$SPARK_VERSION" -DskipTests=true -Dmaven.javadoc.skip=true -B
-V
+ ([[ $SPARK_VERSION != 3.2.* ]] && mvn test -P
"$SCALA_PROFILE,$SPARK_PROFILE,unit-tests" -Dspark.version="$SPARK_VERSION" -pl
hudi-examples/hudi-examples-flink,hudi-examples/hudi-examples-java,hudi-examples/hudi-examples-spark
-DfailIfNoTests=false -D "$SPARK_PROFILE"
-Dscala.binary.version="$SCALA_BINARY_VERSION")
Review comment:
Have you tried put the commands like this to make `SCALA_PROFILE`
effective ?
```suggestion
([[ $SPARK_VERSION != 3.2.* ]] && mvn test -P unit-tests
-Dspark.version="$SPARK_VERSION" -DfailIfNoTests=false -D "$SPARK_PROFILE"
-D"$SCALA_PROFILE" -pl
hudi-examples/hudi-examples-flink,hudi-examples/hudi-examples-java,hudi-examples/hudi-examples-spark)
```
##########
File path: azure-pipelines.yml
##########
@@ -26,6 +26,7 @@ variables:
SPARK_VERSION: '2.4.4'
HADOOP_VERSION: '2.7'
SPARK_ARCHIVE: spark-$(SPARK_VERSION)-bin-hadoop$(HADOOP_VERSION)
+ TESTED_MODULES:
'!hudi-examples/hudi-examples-common,!hudi-examples/hudi-examples-flink,!hudi-examples/hudi-examples-java,!hudi-examples/hudi-examples-spark,!hudi-common,!hudi-flink-datasource/hudi-flink,!hudi-client/hudi-spark-client,!hudi-client/hudi-client-common,!hudi-client/hudi-flink-client,!hudi-client/hudi-java-client,!hudi-cli,!hudi-utilities,!hudi-sync/hudi-hive-sync'
Review comment:
```suggestion
EXCLUDE_TESTED_MODULES:
'!hudi-examples/hudi-examples-common,!hudi-examples/hudi-examples-flink,!hudi-examples/hudi-examples-java,!hudi-examples/hudi-examples-spark,!hudi-common,!hudi-flink-datasource/hudi-flink,!hudi-client/hudi-spark-client,!hudi-client/hudi-client-common,!hudi-client/hudi-flink-client,!hudi-client/hudi-java-client,!hudi-cli,!hudi-utilities,!hudi-sync/hudi-hive-sync'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
