codope commented on a change in pull request #4693:
URL: https://github.com/apache/hudi/pull/4693#discussion_r835755588
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/HoodieBloomIndex.java
##########
@@ -120,7 +120,7 @@ public HoodieBloomIndex(HoodieWriteConfig config,
BaseHoodieBloomIndexHelper blo
// Step 2: Load all involved files as <Partition, filename> pairs
List<Pair<String, BloomIndexFileInfo>> fileInfoList;
if (config.getBloomIndexPruneByRanges()) {
- fileInfoList = (config.getMetadataConfig().isColumnStatsIndexEnabled()
+ fileInfoList = (config.isMetadataColumnStatsIndexEnabled()
Review comment:
yes, and the vice-versa is also possible. If we check for both
partitions, we may not be able to use colstats, e.g. what if bloom_filters is
disabled but column_stats is enbaled, we still need to `lookupIndex` and want
to prune by column ranges right. Checking for both partitions won't help them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
