nsivabalan commented on a change in pull request #4693:
URL: https://github.com/apache/hudi/pull/4693#discussion_r835783252
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/bloom/BloomFilter.java
##########
@@ -30,6 +34,13 @@
*/
void add(String key);
+ /**
+ * Add secondary key to the {@link BloomFilter}.
+ *
+ * @param keys list of secondary keys to add to the {@link BloomFilter}
+ */
+ void add(@Nonnull List<String> keys);
Review comment:
synced up f2f. looks like we are passing in list of secondary col fields
here.
we might need to re-think this fully. from what I understand, we need to
initialize one bloom per every sec key and add the respective col values to the
corresponding bloom filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
