xiarixiaoyao commented on a change in pull request #4910:
URL: https://github.com/apache/hudi/pull/4910#discussion_r837332697
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/MergeOnReadSnapshotRelation.scala
##########
@@ -61,6 +61,11 @@ class MergeOnReadSnapshotRelation(sqlContext: SQLContext,
tableSchema: HoodieTableSchema,
requiredSchema: HoodieTableSchema,
filters: Array[Filter]):
HoodieMergeOnReadRDD = {
+ if (!internalSchema.isEmptySchema) {
+ // it is safe to enable vectorizedReader
+
sqlContext.sparkSession.sessionState.conf.setConfString("spark.sql.parquet.recordLevelFilter.enabled",
"false")
Review comment:
we no need recordLevelFilter.enabled for snapshot read, this
filter only for incremental query， mor incremental query need to filter data
through file level filters
i also post another pr to fixed regression problem
https://github.com/apache/hudi/pull/5168
once merged will remove those code.
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala
##########
@@ -60,6 +60,12 @@ class BaseFileOnlyRelation(sqlContext: SQLContext,
tableSchema: HoodieTableSchema,
requiredSchema: HoodieTableSchema,
filters: Array[Filter]): HoodieUnsafeRDD =
{
+ if (!internalSchema.isEmptySchema) {
+ // it is safe to enable vectorizedReader
+
sqlContext.sparkSession.sessionState.conf.setConfString("spark.sql.parquet.recordLevelFilter.enabled",
"false")
Review comment:
we no need recordLevelFilter.enabled for snapshot read, this
filter only for incremental query， mor incremental query need to filter data
through file level filters
i also post another pr to fixed regression problem
https://github.com/apache/hudi/pull/5168 once merged will remove those
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
