parisni commented on a change in pull request #5167:
URL: https://github.com/apache/hudi/pull/5167#discussion_r837268522
##########
File path:
hudi-aws/src/main/java/org/apache/hudi/aws/transaction/lock/DynamoDBBasedLockProvider.java
##########
@@ -156,9 +156,9 @@ public LockItem getLock() {
private AmazonDynamoDB getDynamoDBClient() {
String region =
this.lockConfiguration.getConfig().getString(DynamoDbBasedLockConfig.DYNAMODB_LOCK_REGION.key());
- String endpointURL =
this.lockConfiguration.getConfig().getString(DynamoDbBasedLockConfig.DYNAMODB_ENDPOINT_URL.key())
== null
- ?
RegionUtils.getRegion(region).getServiceEndpoint(AmazonDynamoDB.ENDPOINT_PREFIX)
- :
this.lockConfiguration.getConfig().getString(DynamoDbBasedLockConfig.DYNAMODB_ENDPOINT_URL.key());
+ String endpointURL =
this.lockConfiguration.getConfig().containsKey(DynamoDbBasedLockConfig.DYNAMODB_ENDPOINT_URL.key())
+ ?
this.lockConfiguration.getConfig().getString(DynamoDbBasedLockConfig.DYNAMODB_ENDPOINT_URL.key())
Review comment:
indeed, well the exact exception was Caused by:
java.lang.IllegalArgumentException: Property
hoodie.write.lock.dynamodb.endpoint_url not found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
