vinothchandar commented on a change in pull request #4693:
URL: https://github.com/apache/hudi/pull/4693#discussion_r838970577
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -538,15 +540,14 @@ private boolean
initializeFromFilesystem(HoodieTableMetaClient dataMetaClient,
// of these large number of files and calling the existing
update(HoodieCommitMetadata) function does not scale
// well. Hence, we have a special commit just for the initialization
scenario.
initialCommit(createInstantTime, enabledPartitionTypes);
- updateCompletedIndexesInTableConfig(enabledPartitionTypes);
+ updateInitializedPartitionsInTableConfig(enabledPartitionTypes);
return true;
}
- private void updateCompletedIndexesInTableConfig(List<MetadataPartitionType>
partitionTypes) {
- Set<String> completedIndexes =
Stream.of(dataMetaClient.getTableConfig().getCompletedMetadataIndexes().split(","))
- .map(String::trim).filter(s ->
!s.isEmpty()).collect(Collectors.toSet());
-
completedIndexes.addAll(partitionTypes.stream().map(MetadataPartitionType::getPartitionPath).collect(Collectors.toList()));
-
dataMetaClient.getTableConfig().setValue(HoodieTableConfig.TABLE_METADATA_INDEX_COMPLETED.key(),
String.join(",", completedIndexes));
+ private void
updateInitializedPartitionsInTableConfig(List<MetadataPartitionType>
partitionTypes) {
+ Set<String> completedIndexes =
getCompletedMetadataPartitions(dataMetaClient.getTableConfig());
Review comment:
completedPartitions
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieTimeline.java
##########
@@ -55,7 +55,7 @@
String COMPACTION_ACTION = "compaction";
String REQUESTED_EXTENSION = ".requested";
String RESTORE_ACTION = "restore";
- String INDEX_ACTION = "index";
+ String INDEX_ACTION = "indexing";
Review comment:
INDEXING_ACTION
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
