vinothchandar commented on a change in pull request #1372: [HUDI-652] Decouple
HoodieReadClient and AbstractHoodieClient to break the inheritance chain
URL: https://github.com/apache/incubator-hudi/pull/1372#discussion_r387725737
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
##########
@@ -144,6 +163,43 @@ private void assertSqlContext() {
}
}
+ private synchronized void startEmbeddedServerView() {
Review comment:
if we have to copy this code, then breaking the abstraction does not feel
right?
I actually think its okay for ReadClient to not use the TimelineServer..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
