alexeykudinkin commented on a change in pull request #5181:
URL: https://github.com/apache/hudi/pull/5181#discussion_r840110259
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -655,4 +786,112 @@ private static Schema resolveNullableSchema(Schema
schema) {
return nonNullType;
}
+
+ // TODO elaborate
+ public static class ConvertingGenericData extends GenericData {
+
+ private static final DecimalConversion DECIMAL_CONVERSION = new
DecimalConversion();
+ private static final Conversions.UUIDConversion UUID_CONVERSION = new
Conversions.UUIDConversion();
+ private static final TimeConversions.DateConversion DATE_CONVERSION = new
TimeConversions.DateConversion();
+ private static final TimeConversions.TimeMillisConversion
TIME_MILLIS_CONVERSION = new TimeConversions.TimeMillisConversion();
Review comment:
Correct, they are not present so had to work their absence around
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -655,4 +786,112 @@ private static Schema resolveNullableSchema(Schema
schema) {
return nonNullType;
}
+
+ // TODO elaborate
+ public static class ConvertingGenericData extends GenericData {
+
+ private static final DecimalConversion DECIMAL_CONVERSION = new
DecimalConversion();
+ private static final Conversions.UUIDConversion UUID_CONVERSION = new
Conversions.UUIDConversion();
+ private static final TimeConversions.DateConversion DATE_CONVERSION = new
TimeConversions.DateConversion();
+ private static final TimeConversions.TimeMillisConversion
TIME_MILLIS_CONVERSION = new TimeConversions.TimeMillisConversion();
Review comment:
Correct, they are not present so had to work around their absence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]