xiarixiaoyao commented on a change in pull request #4910:
URL: https://github.com/apache/hudi/pull/4910#discussion_r840174124
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java
##########
@@ -588,6 +589,9 @@ public void archive(HoodieEngineContext context,
List<HoodieInstant> instants) t
}
}
writeToFile(wrapperSchema, records);
+ // try to clean old history schema.
+ FileBasedInternalSchemaStorageManager fss = new
FileBasedInternalSchemaStorageManager(metaClient);
Review comment:
TimelineArchiver will delete commit files, now history internalSchema
is treaded as commit files。 so i think may be it's better to clean
historySchema here.
of course if you have diff idea, i can move it to cleaner. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
