xiarixiaoyao edited a comment on pull request #4910: URL: https://github.com/apache/hudi/pull/4910#issuecomment-1085877159
> @xiarixiaoyao : Finished reviewing new code changes. Making one final pass now. Meanwhile, please take a look at the comments. > > Also one more comment: Its good that we moved the version definition of caffeine to parent pom file. We would still need a dependency statement in hudi-common/pom.xml (without version) as caffeine is directly used in the code. Can you add the below patch > > ``` > diff --git a/hudi-common/pom.xml b/hudi-common/pom.xml > index f60573875c..ece8d242ce 100644 > --- a/hudi-common/pom.xml > +++ b/hudi-common/pom.xml > @@ -117,6 +117,12 @@ > <artifactId>avro</artifactId> > </dependency> > > + <!-- caffeine --> > + <dependency> > + <groupId>com.github.ben-manes.caffeine</groupId> > + <artifactId>caffeine</artifactId> > + </dependency> > + > <!-- Parquet --> > <dependency> > <groupId>org.apache.parquet</groupId> > ``` @bvaradar Thanks for reminding, already addressed all comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
