yihua commented on a change in pull request #5199:
URL: https://github.com/apache/hudi/pull/5199#discussion_r840752006
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java
##########
@@ -372,6 +372,8 @@ public void completeCompaction(
} finally {
this.txnManager.endTransaction(Option.of(compactionInstant));
}
+ WriteMarkersFactory.get(config.getMarkersType(), table,
compactionCommitTime)
+ .quietDeleteMarkerDir(context, config.getMarkersDeleteParallelism());
Review comment:
Should this happen just before completing inflight compaction
(`CompactHelpers.getInstance().completeInflightCompaction(table,
compactionCommitTime, metadata);`) for readability?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java
##########
@@ -165,7 +165,7 @@ public Schema getTableAvroSchema(boolean
includeMetadataFields) throws Exception
if (includeMetadataFields) {
return HoodieAvroUtils.addMetadataFields(schemaFromTableConfig.get(),
hasOperationField);
} else {
- return schemaFromTableConfig.get();
+ return
HoodieAvroUtils.removeMetadataFields(schemaFromTableConfig.get());
Review comment:
why is this changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
