alexeykudinkin commented on code in PR #5208:
URL: https://github.com/apache/hudi/pull/5208#discussion_r842251300
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -315,7 +312,7 @@ public Builder withPartition(String partitionName) {
public HoodieMergedLogRecordScanner build() {
return new HoodieMergedLogRecordScanner(fs, basePath, logFilePaths,
readerSchema,
latestInstantTime, maxMemorySizeInBytes, readBlocksLazily,
reverseReader,
- bufferSize, spillableMapBasePath, instantRange, autoScan,
+ bufferSize, spillableMapBasePath, instantRange,
diskMapType, isBitCaskDiskMapCompressionEnabled, withOperationField,
true,
Review Comment:
So what's `forceFullScan` was `enableFullScan` before and it was always
hard-coded to true.
Here, i'm simplifying the configuration as it's getting out of hand (there
was `autoScan`, `enableFullScan` etc which actually were doing the same thing
but on different levels) and keep just the `forceFullScan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
