codope commented on code in PR #5208:
URL: https://github.com/apache/hudi/pull/5208#discussion_r843746688
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -390,8 +390,12 @@ private HoodieMetadataColumnStats
combineColumnStatsMetadata(HoodieMetadataPaylo
return combineAndGetUpdateValue(oldRecord, schema, new Properties());
}
+ public Option<IndexedRecord> getInsertValue() throws IOException {
+ return getInsertValue(null, null);
Review Comment:
not really needed, i think we can pass `null` from the caller itself and
mention that generating metadata record doesn't rally depend on schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
