alexeykudinkin commented on code in PR #5274:
URL: https://github.com/apache/hudi/pull/5274#discussion_r846804960
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -770,18 +774,6 @@ private MetadataRecordsGenerationParams
getRecordsGenerationParams() {
}
}
- private Set<String> getMetadataPartitionsToUpdate() {
Review Comment:
Sorry, i'm not sure i understand what's not going to work in these
scenarios.
Let's take a closer look at what i'm removing:
```
// fetch partitions to update from table config
Set<String> partitionsToUpdate =
getCompletedMetadataPartitions(dataMetaClient.getTableConfig());
// add inflight indexes as well because the file groups have already
been initialized, so writers can log updates
partitionsToUpdate.addAll(getInflightMetadataPartitions(dataMetaClient.getTableConfig()));
if (!partitionsToUpdate.isEmpty()) {
return partitionsToUpdate;
}
// fallback to all enabled partitions if table config returned no
partitions
return
getEnabledPartitionTypes().stream().map(MetadataPartitionType::getPartitionPath).collect(Collectors.toSet());
```
As you can see, we always add both already _completed_ and _inflight_
partitions as the ones in need of update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
