codope commented on code in PR #5255:
URL: https://github.com/apache/hudi/pull/5255#discussion_r846941822
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestTransactionManager.java:
##########
@@ -152,6 +165,32 @@ public void testMultiWriterTransactions() {
Assertions.assertTrue(writer2Completed.get());
}
+ @Test
+ public void testEndTransactionByDiffOwner() throws InterruptedException {
+ // 1. Begin and end by the same transaction owner
+ Option<HoodieInstant> lastCompletedInstant = getInstant("0000001");
+ Option<HoodieInstant> newTxnOwnerInstant = getInstant("0000002");
+ transactionManager.beginTransaction(newTxnOwnerInstant,
lastCompletedInstant);
+
+ CountDownLatch countDownLatch = new CountDownLatch(1);
+ // Another writer thread
+ Thread writer2 = new Thread(() -> {
+ Option<HoodieInstant> newTxnOwnerInstant1 = getInstant("0000003");
+ transactionManager.endTransaction(newTxnOwnerInstant1);
+ countDownLatch.countDown();
+ });
+
+ writer2.start();
+ countDownLatch.await(30, TimeUnit.SECONDS);
+ // should not have reset the state within transaction manager since the
owner is different.
+
Assertions.assertTrue(transactionManager.getCurrentTransactionOwner().isPresent());
Review Comment:
Ok found it:
`TestInProcessLockProvider#testLockReAcquisitionByDifferentThread`. That's good
enough.
Since we already use Mocito, maybe we can use its verify API to just verify
calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
