smarthi commented on a change in pull request #1379: [HUDI-670] Added unit-test
for DiskBasedMap.
URL: https://github.com/apache/incubator-hudi/pull/1379#discussion_r389316363
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestDiskBasedMap.java
##########
@@ -184,6 +187,28 @@ public void testSizeEstimator() throws IOException,
URISyntaxException {
assertTrue(payloadSize > 0);
}
+ @Test
+ public void testPutAll() throws IOException, URISyntaxException {
+ DiskBasedMap<String, HoodieRecord> records = new DiskBasedMap<String,
HoodieRecord>(basePath);
+ List<IndexedRecord> iRecords = SchemaTestUtil.generateHoodieTestRecords(0,
100);
+ Map<String, HoodieRecord> recordMap = new HashMap<String, HoodieRecord>();
Review comment:
change to Map<String, HoodieRecord> recordMap = new HashMap<>();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
