danny0405 commented on code in PR #5201:
URL: https://github.com/apache/hudi/pull/5201#discussion_r849036618
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -324,13 +336,19 @@ public static GenericRecord
addOperationToRecord(GenericRecord record, HoodieOpe
* @param newFieldNames Null Field names to be added
*/
public static Schema appendNullSchemaFields(Schema schema, List<String>
newFieldNames) {
- List<Field> newFields = schema.getFields().stream()
- .map(field -> new Field(field.name(), field.schema(), field.doc(),
field.defaultVal())).collect(Collectors.toList());
+ List<Field> newFields = new ArrayList<>();
for (String newField : newFieldNames) {
newFields.add(new Schema.Field(newField, METADATA_FIELD_SCHEMA, "",
JsonProperties.NULL_VALUE));
}
+ return createNewSchemaWithExtraFields(schema, newFields);
+ }
+
+ public static Schema createNewSchemaWithExtraFields(Schema schema,
List<Field> newFields) {
+ List<Field> fields = schema.getFields().stream()
Review Comment:
Can we give some documentation to this method ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
