yihua commented on code in PR #5308:
URL: https://github.com/apache/hudi/pull/5308#discussion_r849137873
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1453,43 +1453,43 @@ public String getHbaseTableName() {
}
public int getHbaseIndexGetBatchSize() {
- return getInt(HoodieHBaseIndexConfig.GET_BATCH_SIZE);
+ return getIntOrDefault(HoodieHBaseIndexConfig.GET_BATCH_SIZE);
Review Comment:
Thanks for reporting the issue. Actually, all of these changes are not
needed if the `HoodieHBaseIndexConfig` defaults are set properly. It looks
like that the root cause is that the builder of `HoodieWriteConfig` does not
set defaults for `HoodieHBaseIndexConfig` in `setDefaults()`, like other Hudi
config class. Could you fix that and revert all getter changes instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
