danny0405 commented on code in PR #4910:
URL: https://github.com/apache/hudi/pull/4910#discussion_r849166971


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/RunCompactionActionExecutor.java:
##########
@@ -70,8 +73,19 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> 
execute() {
       HoodieCompactionPlan compactionPlan =
           CompactionUtils.getCompactionPlan(table.getMetaClient(), 
instantTime);
 
+      // try to load internalSchema to support schema Evolution
+      HoodieWriteConfig configCopy = config;
+      Pair<Option<String>, Option<String>> schemaPair = InternalSchemaCache

Review Comment:
   What is the purpose we re-assign the config to `configCopy` and modify it 
directly ? I mean, you should either modify the `config` directly or copy the 
whole config to `configCopy` !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to