XuQianJin-Stars commented on code in PR #5320:
URL: https://github.com/apache/hudi/pull/5320#discussion_r850974829


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableRenameCommand.scala:
##########
@@ -46,6 +46,17 @@ class AlterHoodieTableRenameCommand(
 
       // Call AlterTableRenameCommand#run to rename table in meta.
       super.run(sparkSession)
+
+      // update table properties: path
+      if (hoodieCatalogTable.catalogProperties.contains("path")) {
+        val catalogTable = 
sparkSession.sessionState.catalog.getTableMetadata(newName)
+        if (catalogTable.tableType == CatalogTableType.MANAGED) {

Review Comment:
   > just consistent with metastore design logic. For **MANGED** table, ms will 
update storage location automatically when rename table, but **EXTERNAL** will 
not
   
   Does not automatically update, do HMS synchronization API modification, 
catalog table refresh can also be satisfied?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to