nsivabalan commented on code in PR #5377:
URL: https://github.com/apache/hudi/pull/5377#discussion_r854755407
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -820,8 +818,8 @@ public PropertyBuilder
setPartitionMetafileUseBaseFormat(Boolean useBaseFormat)
return this;
}
- public PropertyBuilder setDropPartitionColumnsWhenWrite(Boolean
dropPartitionColumnsWhenWrite) {
Review Comment:
having "write" in the name makes is clear. If not, one could read it as
"should drop partition columns when reading". So, I feel we can leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
