KnightChess commented on code in PR #5359:
URL: https://github.com/apache/hudi/pull/5359#discussion_r853201697
##########
hudi-spark-datasource/hudi-spark/pom.xml:
##########
@@ -434,6 +434,12 @@
<version>${zk-curator.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.aventrix.jnanoid</groupId>
+ <artifactId>jnanoid</artifactId>
+ <version>2.0.0</version>
Review Comment:
nit
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala:
##########
@@ -1017,6 +1017,48 @@ class TestHoodieSparkSqlWriter {
}
}
+ @Test
+ def testUuidKeyGen(): Unit = {
+ try {
+ val _spark = spark
+ import _spark.implicits._
+ val df = Seq((1, "a1", 10, 1000, "2021-10-16")).toDF("id", "name",
"value", "ts", "dt")
+ val options = Map(
+ DataSourceWriteOptions.PRECOMBINE_FIELD.key -> "ts",
+ DataSourceWriteOptions.PARTITIONPATH_FIELD.key -> "dt")
+ val (tableName1, tablePath1) = ("hoodie_test_params_1", s"$tempBasePath"
+ "_1")
+
+ df.write.format("hudi")
+ .options(options)
+ .option(HoodieWriteConfig.TBL_NAME.key, tableName1)
+ .option(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key,
classOf[UuidKeyGenerator].getName)
+ .mode(SaveMode.Overwrite).save(tablePath1)
+ } catch {
+ case _ => fail("Failing when using UUIDKeyGenerator.");
+ }
+ }
+
+ @Test
+ def testNanoIdKeyGen(): Unit = {
+ try {
+ val _spark = spark
+ import _spark.implicits._
+ val df = Seq((1, "a1", 10, 1000, "2021-10-16")).toDF("id", "name",
"value", "ts", "dt")
+ val options = Map(
+ DataSourceWriteOptions.PRECOMBINE_FIELD.key -> "ts",
+ DataSourceWriteOptions.PARTITIONPATH_FIELD.key -> "dt")
+ val (tableName1, tablePath1) = ("hoodie_test_params_1", s"$tempBasePath"
+ "_1")
+
+ df.write.format("hudi")
+ .options(options)
+ .option(HoodieWriteConfig.TBL_NAME.key, tableName1)
+ .option(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key,
classOf[NanoidKeyGenerator].getName)
+ .mode(SaveMode.Overwrite).save(tablePath1)
+ } catch {
+ case _ => fail("Failing when using UUIDKeyGenerator.");
Review Comment:
nit: NanoId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
