yanghua commented on a change in pull request #1388: [HUDI-681]Remove
embeddedTimelineService from HoodieReadClient
URL: https://github.com/apache/incubator-hudi/pull/1388#discussion_r390047183
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
##########
@@ -100,14 +91,6 @@ public HoodieReadClient(JavaSparkContext jsc, String
basePath, SQLContext sqlCon
* @param clientConfig instance of HoodieWriteConfig
*/
public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig
clientConfig) {
- this(jsc, clientConfig, Option.empty());
- }
-
- /**
- * @param clientConfig instance of HoodieWriteConfig
- */
- public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig clientConfig,
- Option<EmbeddedTimelineService> timelineService) {
Review comment:
@bvaradar I and @vinothchandar discussed before, we agreed on that
`HoodieReadClient ` will be moved into hudi-spark module in the future.
Currently, we found `EmbeddedTimelineService` did not take effect in
`HoodieReadClient`.
About making `EmbeddedTimelineService` spark-free, I have filed an issue to
track this work: https://issues.apache.org/jira/browse/HUDI-661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
