alexeykudinkin commented on code in PR #5424:
URL: https://github.com/apache/hudi/pull/5424#discussion_r857987774
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -151,7 +154,7 @@ object HoodieSparkSqlWriter {
.setBaseFileFormat(baseFileFormat)
.setArchiveLogFolder(archiveLogFolder)
.setPayloadClassName(hoodieConfig.getString(PAYLOAD_CLASS_NAME))
-
.setPreCombineField(hoodieConfig.getStringOrDefault(PRECOMBINE_FIELD, null))
+ .setPreCombineField(optParams.getOrElse(PRECOMBINE_FIELD.key(),
null))
Review Comment:
Please add a comment elaborating why this is channelled from `optParams` and
not `hoodieConfig` like everything else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
