nsivabalan commented on code in PR #5430:
URL: https://github.com/apache/hudi/pull/5430#discussion_r858193317
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala:
##########
@@ -127,9 +130,9 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
// then we can avoid reading and parsing the records w/ _full_
schema, and instead only
// rely on projected one, nevertheless being able to perform merging
correctly
if (!whitelistedPayloadClasses.contains(tableState.recordPayloadClassName))
- (fullSchemaFileReader(split.dataFile.get), dataSchema)
+ (fileReaders.fullSchemaFileReader(split.dataFile.get), dataSchema)
else
- (requiredSchemaFileReader(split.dataFile.get), requiredSchema)
+ (fileReaders.requiredSchemaForMergingFileReader(split.dataFile.get),
requiredSchema)
Review Comment:
is this not a base file and so shouldn't we use
requiredSchemaForNoMergingFileReader ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]