danny0405 commented on code in PR #5434:
URL: https://github.com/apache/hudi/pull/5434#discussion_r859326135
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FilePathUtils.java:
##########
@@ -420,9 +420,9 @@ public static org.apache.flink.core.fs.Path
toFlinkPath(Path path) {
* @return array of the partition fields
*/
public static String[]
extractPartitionKeys(org.apache.flink.configuration.Configuration conf) {
- if (FlinkOptions.isDefaultValueDefined(conf,
FlinkOptions.PARTITION_PATH_FIELD)) {
+ if (FlinkOptions.isDefaultValueDefined(conf,
FlinkOptions.HIVE_SYNC_PARTITION_FIELDS)) {
return new String[0];
}
- return conf.getString(FlinkOptions.PARTITION_PATH_FIELD).split(",");
+ return conf.getString(FlinkOptions.HIVE_SYNC_PARTITION_FIELDS).split(",");
}
Review Comment:
You also need to write a test case i guess. A unit test for HiveSyncContext
is okey i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
