danny0405 commented on code in PR #5185:
URL: https://github.com/apache/hudi/pull/5185#discussion_r857474363
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -185,5 +209,30 @@ private void bootstrapIndexIfNeed(String partition) {
}
});
bucketIndex.put(partition, bucketToFileIDMap);
+
Review Comment:
I guess we only need to fix line 197 using:
```java
getLatestFileSlicesBeforeOrOn(String partitionPath, String maxCommitTime,
boolean includeFileSlicesInPendingCompaction)
```
with includeFileSlicesInPendingCompaction as true.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -80,6 +93,11 @@
*/
private boolean isEmptyTable;
+ /**
+ * Returns whether this is an empty table.
+ */
Review Comment:
nit: fix the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
