JerryYue-M commented on PR #5445: URL: https://github.com/apache/hudi/pull/5445#issuecomment-1113184914
> > > > > > > > > @danny0405 there are some question for the API patch > > > > 1. DDL needs a type for each column. So users must provide a string type to make > > > > > > Can you also apply the patch and rewrite the tests then ? There is no need to add methods to `Pipelines` clazz now. > > > > ok, I will apply the patch and rewrite the tests > > > > @danny0405 > > > > there are some question about the API patch > > > > > > > > 1. no need to cancat a DDL SQL for creating a table in the catalog and then get the table later instead of just creating a table instance, no need to import table env. > > 2. cancat a DDL need type for each column. if we do this. user must specify field and type string. it's not good > > 3. maybe we can build a catalog table without import DDL and table env > > How to build a catalog table then, we have no API for building the schema and resolve it. @danny0405 I push new pr for this issue can you review it again very thankful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
