alexeykudinkin commented on code in PR #5462:
URL: https://github.com/apache/hudi/pull/5462#discussion_r862169457
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowCreateHandle.java:
##########
@@ -107,16 +107,15 @@ public HoodieRowCreateHandle(HoodieTable table,
HoodieWriteConfig writeConfig, S
/**
* Writes an {@link InternalRow} to the underlying
HoodieInternalRowFileWriter. Before writing, value for meta columns are
computed as required
* and wrapped in {@link HoodieInternalRow}. {@link HoodieInternalRow} is
what gets written to HoodieInternalRowFileWriter.
+ *
* @param record instance of {@link InternalRow} that needs to be written to
the fileWriter.
* @throws IOException
*/
public void write(InternalRow record) throws IOException {
try {
- String partitionPath =
record.getUTF8String(HoodieRecord.HOODIE_META_COLUMNS_NAME_TO_POS.get(
- HoodieRecord.PARTITION_PATH_METADATA_FIELD)).toString();
+ String partitionPath = record.getUTF8String(3).toString();
Review Comment:
Pardon confusion, let me elaborate: let's avoid magic constants, it's
actually not a problem to do map lookup here, but if you prefer you can create
static constant for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
