alexeykudinkin commented on code in PR #5393:
URL: https://github.com/apache/hudi/pull/5393#discussion_r866304797
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -840,13 +840,9 @@ private static Object rewriteRecordWithNewSchema(Object
oldRecord, Schema oldSch
}
private static String createFullName(Deque<String> fieldNames) {
- String result = "";
- if (!fieldNames.isEmpty()) {
- List<String> parentNames = new ArrayList<>();
- fieldNames.descendingIterator().forEachRemaining(parentNames::add);
- result = parentNames.stream().collect(Collectors.joining("."));
- }
- return result;
+ return StreamSupport
Review Comment:
No need for Stream you can just do `String.join`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
