vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace
Guava's Hashing with an equivalent in NumericUtils.java
URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392047003
##########
File path:
hudi-client/src/main/java/org/apache/hudi/index/bloom/BucketizedBloomCheckPartitioner.java
##########
@@ -144,7 +144,12 @@ public int numPartitions() {
@Override
public int getPartition(Object key) {
final Pair<String, String> parts = (Pair<String, String>) key;
- final long hashOfKey = Hashing.md5().hashString(parts.getRight(),
StandardCharsets.UTF_8).asLong();
+ long hashOfKey = 0L;
Review comment:
can we move this try-catch block to a method for reuse? Also let's have
that throw a `HoodieRuntimeException` instead of logging the error.. we cannot
really make reasonable progress otherwise.. ?
Should we change from MD5 to something else? We are not doing anything
secure here.. just want something that will give good uniform hashing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
