pratyakshsharma commented on a change in pull request #1395: [HUDI-667] Fixing
delete tests for DeltaStreamer
URL: https://github.com/apache/incubator-hudi/pull/1395#discussion_r392120925
##########
File path:
hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -429,24 +428,24 @@ public HoodieRecord generateUpdateRecord(HoodieKey key,
String commitTime) throw
*/
public Stream<HoodieKey> generateUniqueDeleteStream(Integer n) {
final Set<KeyPartition> used = new HashSet<>();
-
if (n > numExistingKeys) {
throw new IllegalArgumentException("Requested unique deletes is greater
than number of available keys");
}
- return IntStream.range(0, n).boxed().map(i -> {
- int index = numExistingKeys == 1 ? 0 : RAND.nextInt(numExistingKeys - 1);
- KeyPartition kp = existingKeys.get(index);
- // Find the available keyPartition starting from randomly chosen one.
- while (used.contains(kp)) {
+ List<HoodieKey> result = new ArrayList<>();
+ for (int i = 0; i < n; i++) {
+ int index = RAND.nextInt(numExistingKeys);
+ while (!existingKeys.containsKey(index)) {
index = (index + 1) % numExistingKeys;
- kp = existingKeys.get(index);
}
- existingKeys.remove(kp);
+ KeyPartition kp = existingKeys.remove(index);
+ existingKeys.put(index, existingKeys.get(numExistingKeys - 1));
+ existingKeys.remove(numExistingKeys - 1);
Review comment:
this line is solving the use case that you pointed out in jira
@prashantwason . I guess the fix is complete and good to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
