wzx140 commented on code in PR #5522:
URL: https://github.com/apache/hudi/pull/5522#discussion_r870902865


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -243,14 +235,32 @@ private Option<IndexedRecord> 
getIndexedRecord(HoodieRecord<T> hoodieRecord) {
       // part of marking
       // record successful.
       hoodieRecord.deflate();
-      return avroRecord;
+      return finalRecord;
     } catch (Exception e) {
       LOG.error("Error writing record  " + hoodieRecord, e);
       writeStatus.markFailure(hoodieRecord, e, recordMetadata);
     }
     return Option.empty();
   }
 
+  private HoodieRecord populateMetadataFields(HoodieRecord<T> hoodieRecord, 
Schema schema, Properties prop) throws IOException {

Review Comment:
   We only use populateMetadataFields func in HoodieAppendHandle. And 
populateMetadataFields alse use some instance variable in HoodieAppendHandle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to