[ https://issues.apache.org/jira/browse/HUDI-2151 ]
Raymond Xu deleted comment on HUDI-2151:
----------------------------------
was (Author: githubbot):
nsivabalan commented on a change in pull request #3452:
URL: https://github.com/apache/hudi/pull/3452#discussion_r688771638
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -81,7 +81,7 @@
public static final ConfigProperty<HoodieTableVersion>
HOODIE_TABLE_VERSION_PROP = ConfigProperty
.key("hoodie.table.version")
- .defaultValue(HoodieTableVersion.ZERO)
+ .defaultValue(HoodieTableVersion.ONE)
Review comment:
I don't see the upgrade kicking in actually. So, here is what is
happening.
if hoodie.properties does not have any table version, this default value
kicks in.
So, for a table created with 052, if I use this patch to trigger an insert,
I don't see an upgrade kicking in. bcoz, the hoodie.props will not have any
table version and so this default gets picked up.
Looks like, we might have to leave the default version as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Make performant out-of-box configs
> ----------------------------------
>
> Key: HUDI-2151
> URL: https://issues.apache.org/jira/browse/HUDI-2151
> Project: Apache Hudi
> Issue Type: Improvement
> Components: code-quality, docs, writer-core
> Reporter: Vinoth Chandar
> Assignee: sivabalan narayanan
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 0.12.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> We have quite a few configs which deliver better performance or usability,
> but guarded by flags.
> This is to identify them, change them, test (functionally, perf) and make
> them default
>
> Need to ensure we also capture all the backwards compatibility issues that
> can arise
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
