fengjian428 commented on PR #4676: URL: https://github.com/apache/hudi/pull/4676#issuecomment-1124933882
> @fengjian428 Thanks for adding integ test. I would recommend if you can extract the integ test to a separate PR then it would be easier to review this one. When I said > > > can we also add some end-to-end test with payload class config changed, one for deltastreamer with compaction and another for datasource with compaction? > > what i meant is that a deltastreamer and datasource unit test which writes with this new payload class and then validates the data. See how tests in `TestHoodieDeltaStreamer` and `TestHoodieSparkMergeOnReadTableCompaction` are setup. We need to change the payload class config there. > > So, let's keep integration test in a separate PR and add unit tests as suggested above in this PR. This way we can isolate failures if any and fix them sooner. Sure, will create another pr for integ-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
