yanghua commented on a change in pull request #1401: [HUDI-694]Add unit test for SparkEnvCommand URL: https://github.com/apache/incubator-hudi/pull/1401#discussion_r392679340
########## File path: hudi-cli/src/test/java/org/apache/hudi/cli/AbstractShellIntegrationTest.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.cli; + +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.springframework.shell.Bootstrap; +import org.springframework.shell.core.JLineShellComponent; + +/** + * Class to start Bootstrap and JLineShellComponent. + */ +public abstract class AbstractShellIntegrationTest { + private static JLineShellComponent shell; + + @BeforeClass + public static void startUp() throws InterruptedException { Review comment: - to keep the same style with `shutdown`, can we rename the name of the method to `startup`? - here we may not need to throw `InterruptedException ` clearly? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
