XuQianJin-Stars commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r873384805
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -612,6 +623,21 @@ public void initializeBootstrapDirsIfNotExists() throws
IOException {
initializeBootstrapDirsIfNotExists(getHadoopConf(), basePath.toString(),
getFs());
}
+ private static HoodieTableMetaClient newMetaClient(Configuration conf,
String basePath, boolean loadActiveTimelineOnLoad,
+ ConsistencyGuardConfig consistencyGuardConfig,
Option<TimelineLayoutVersion> layoutVersion,
+ String payloadClassName, FileSystemRetryConfig fileSystemRetryConfig,
Properties props) {
+ HoodieMetastoreConfig metastoreConfig = null == props
+ ? new HoodieMetastoreConfig.Builder().build()
+ : new HoodieMetastoreConfig.Builder().fromProperties(props).build();
+ return metastoreConfig.enableMetastore()
+ ? (HoodieTableMetaClient)
ReflectionUtils.loadClass("org.apache.hudi.common.table.HoodieTableMetastoreClient",
Review Comment:
> hudi-metastore
after `hudi-metastore` ready, can remove this reflection. add some note for
this code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
