dongkelun commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873477947
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
Review Comment:
> This SQL makes me confused. Should the table identifier be consistent with
the property of "hoodie.database.name" ?
>
> I mean the CTAS should start with "create table databaseName.$tableName"
It doesn't have to be set. It has a default value in `HoodieCatalogTable`
```scala
val hoodieDatabaseName = formatName(spark,
table.identifier.database.getOrElse(spark.sessionState.catalog.getCurrentDatabase))
HoodieTableMetaClient.withPropertyBuilder()
.fromProperties(properties)
.setDatabaseName(hoodieDatabaseName)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
