umehrot2 commented on a change in pull request #1406: [HUDI-713] Fix conversion
of Spark array of struct type to Avro schema
URL: https://github.com/apache/incubator-hudi/pull/1406#discussion_r394069828
##########
File path:
hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -81,10 +82,12 @@
+ "{\"name\": \"end_lat\", \"type\": \"double\"}," + "{\"name\":
\"end_lon\", \"type\": \"double\"},"
+ "{\"name\": \"fare\",\"type\": {\"type\":\"record\",
\"name\":\"fare\",\"fields\": ["
+ "{\"name\": \"amount\",\"type\": \"double\"},{\"name\": \"currency\",
\"type\": \"string\"}]}},"
+ + "{\"name\": \"tip_history\", \"type\": {\"type\": \"array\",
\"items\": {\"type\": \"record\", \"name\": \"tip\", \"fields\": ["
+ + "{\"name\": \"amount\", \"type\": \"double\"}, {\"name\":
\"currency\", \"type\": \"string\"}]}}},"
Review comment:
From what I understand, and if you look at the schema generated by Hudi as
well..shouldn't the record name `tip` also be `tip_history` instead ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
