danny0405 commented on code in PR #5393:
URL: https://github.com/apache/hudi/pull/5393#discussion_r878971642
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java:
##########
@@ -826,7 +826,7 @@ private static Object rewriteRecordWithNewSchema(Object
oldRecord, Schema oldSch
}
Map<Object, Object> map = (Map<Object, Object>) oldRecord;
Map<Object, Object> newMap = new HashMap<>();
- fieldNames.push("value");
+ fieldNames.push(MAP_TYPE_VALUE_NAME);
Review Comment:
If the variable only used by this method, there is no need to make static
variables, the JVM would cache the string constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
