danny0405 commented on code in PR #5660:
URL: https://github.com/apache/hudi/pull/5660#discussion_r879994504
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -298,20 +298,13 @@ public HoodieTableConfig() {
private void fetchConfigs(FileSystem fs, String metaPath) throws IOException
{
Path cfgPath = new Path(metaPath, HOODIE_PROPERTIES_FILE);
- Path backupCfgPath = new Path(metaPath, HOODIE_PROPERTIES_FILE_BACKUP);
try (FSDataInputStream is = fs.open(cfgPath)) {
props.load(is);
- // validate checksum for latest table version
- if (getTableVersion().versionCode() >=
HoodieTableVersion.FOUR.versionCode() && !isValidChecksum()) {
- LOG.warn("Checksum validation failed. Falling back to backed up
configs.");
- try (FSDataInputStream fsDataInputStream = fs.open(backupCfgPath)) {
- props.load(fsDataInputStream);
- }
- }
Review Comment:
The current code is problematic, based on the fact the config file and
backup config file can only exists one at a time point. We already check the
checksum in the modification code path. There is no need to check again in the
read path.
And falling back to backup file is not a reasonable way, more proper to
throws exception here, but i would let @codope do that in following PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
