danny0405 commented on code in PR #5247:
URL: https://github.com/apache/hudi/pull/5247#discussion_r880035427
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -213,7 +213,7 @@ public Result inputSplits(
}
HoodieTableFileSystemView fsView = new
HoodieTableFileSystemView(metaClient, commitTimeline, fileStatuses);
- final String endInstant = instantToIssue.getTimestamp();
+ final String endInstant = instantRange == null ?
fsView.getLastInstant().get().getTimestamp() : instantToIssue.getTimestamp();
final AtomicInteger cnt = new AtomicInteger(0);
Review Comment:
I'm confused, when `instantRange == null` is true, that means the user first
time query from earliest, and we should read to the latest commit instant,
which should be `instantToIssue` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
