cuibo01 commented on code in PR #5675:
URL: https://github.com/apache/hudi/pull/5675#discussion_r881654513
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FormatUtils.java:
##########
@@ -241,9 +250,9 @@ public static HoodieMergedLogRecordScanner logScanner(
.withReadBlocksLazily(writeConfig.getCompactionLazyBlockReadEnabled())
.withReverseReader(false)
.withBufferSize(writeConfig.getMaxDFSStreamBufferSize())
- .withMaxMemorySizeInBytes(writeConfig.getMaxMemoryPerPartitionMerge())
+ .withMaxMemorySizeInBytes(diskMapType ==
ExternalSpillableMap.DiskMapType.ROCKS_DB ? 0 :
writeConfig.getMaxMemoryPerPartitionMerge())
.withSpillableMapBasePath(writeConfig.getSpillableMapBasePath())
Review Comment:
WDYT? in our production env, memory cache has not been disabled yet, but the
rocksdb has its own memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
