xushiyan commented on code in PR #5637:
URL: https://github.com/apache/hudi/pull/5637#discussion_r882357471
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -57,7 +64,11 @@ public class HoodieIndexConfig extends HoodieConfig {
public static final ConfigProperty<String> INDEX_TYPE = ConfigProperty
.key("hoodie.index.type")
- .noDefaultValue()
+ .defaultValue(SIMPLE.name())
Review Comment:
@wzx140 i now think it should be better to leave it `noDefaultValue()` given
it'll be controlled by `getDefaultIndexType()` from
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
