vinothchandar commented on issue #1377: [HUDI-663] Fix HoodieDeltaStreamer 
offset not handled correctly
URL: https://github.com/apache/incubator-hudi/pull/1377#issuecomment-601303031
 
 
   
>https://github.com/apache/incubator-hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java#L331
   This is handling the case that the transformer filtered everything out, but 
we want to do an empty commit to record that the offsets moved.
   
   The resets happening around Kafka, should be left alone IMO.. It can happen 
due to variety of reasons like topic retention kicking in etc.. 
   
   For this PR, I am not sure if we want to special case an empty string.. ? 
Can we formulate the problem we are trying to solve again..  
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to