alexeykudinkin commented on code in PR #5699:
URL: https://github.com/apache/hudi/pull/5699#discussion_r883268361
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -108,9 +108,6 @@ case class HoodieFileIndex(spark: SparkSession,
* @return list of PartitionDirectory containing partition to base files
mapping
*/
override def listFiles(partitionFilters: Seq[Expression], dataFilters:
Seq[Expression]): Seq[PartitionDirectory] = {
- val convertedPartitionFilters =
Review Comment:
MOR still does the conversion w/in the Relation itself
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -399,7 +399,9 @@ abstract class HoodieBaseRelation(val sqlContext:
SQLContext,
protected def getPartitionColumnsAsInternalRow(file: FileStatus):
InternalRow = {
try {
val tableConfig = metaClient.getTableConfig
- if (shouldExtractPartitionValuesFromPartitionPath) {
+ if (partitionColumns.isEmpty) {
Review Comment:
Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
