watermelon12138 commented on code in PR #5688:
URL: https://github.com/apache/hudi/pull/5688#discussion_r883310409
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -88,11 +88,11 @@ public BaseRollbackActionExecutor(HoodieEngineContext
context,
this.resolvedInstant = instantToRollback;
this.deleteInstants = deleteInstants;
this.skipTimelinePublish = skipTimelinePublish;
- this.useMarkerBasedStrategy = useMarkerBasedStrategy;
- if (useMarkerBasedStrategy) {
- ValidationUtils.checkArgument(!instantToRollback.isCompleted(),
- "Cannot use marker based rollback strategy on completed instant:" +
instantToRollback);
+ if (instantToRollback.isCompleted() && useMarkerBasedStrategy) {
+ useMarkerBasedStrategy = false;
+ LOG.warn("Cannot use marker based rollback strategy on completed
instant:" + instantToRollback + ", the strategy has been automatically
disabled.");
Review Comment:
@xushiyan @yihua ok，i see. I have changed the jira type from bug to
improvement. And the reason why CI fail is that some uts expect
IllegalArgumentException during the rollback of the completed commit. Is that
normal? why can't we just roll back completed instant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
