bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of
HiveDriver for DDL statements for Hive 2.x
URL: https://github.com/apache/incubator-hudi/pull/1416#discussion_r395337083
##########
File path:
hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -198,7 +198,8 @@ private String getPartitionClause(String partition) {
for (String partition : partitions) {
String partitionClause = getPartitionClause(partition);
Path partitionPath = FSUtils.getPartitionPath(syncConfig.basePath,
partition);
- String fullPartitionPath =
partitionPath.toUri().getScheme().equals(StorageSchemes.HDFS.getScheme())
+ String partitionScheme = partitionPath.toUri().getScheme();
+ String fullPartitionPath =
StorageSchemes.HDFS.getScheme().equals(partitionScheme)
Review comment:
No, I think it does support cloud stores. This special handling was part of
https://jira.apache.org/jira/browse/HUDI-325 to get correct behavior for HDFS
for alter partitions. This should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
