[ https://issues.apache.org/jira/browse/HUDI-2187 ]
Raymond Xu deleted comment on HUDI-2187:
----------------------------------
was (Author: githubbot):
leesf commented on a change in pull request #3289:
URL: https://github.com/apache/hudi/pull/3289#discussion_r677539486
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -86,17 +85,17 @@ public HoodieHiveClient(HiveSyncConfig cfg, HiveConf
configuration, FileSystem f
} else {
ddlExecutor = cfg.useJdbc ? new JDBCExecutor(cfg, fs) : new
HiveQueryDDLExecutor(cfg, fs, configuration);
}
- this.client = Hive.get(configuration).getMSC();
+ this.client = HiveMetastoreClientFactory.create(configuration,
cfg.hiveVersion == null ? HiveShimLoader.getHiveVersion() : cfg.hiveVersion);
} catch (Exception e) {
throw new HoodieHiveSyncException("Failed to create
HiveMetaStoreClient", e);
}
try {
this.partitionValueExtractor =
- (PartitionValueExtractor)
Class.forName(cfg.partitionValueExtractorClass).newInstance();
+ (PartitionValueExtractor)
Class.forName(cfg.partitionValueExtractorClass).newInstance();
Review comment:
unrelated changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [RFC-31] Add shim layer to support multiple hive version
> --------------------------------------------------------
>
> Key: HUDI-2187
> URL: https://issues.apache.org/jira/browse/HUDI-2187
> Project: Apache Hudi
> Issue Type: Improvement
> Components: hive
> Reporter: zhangminglei
> Assignee: Raymond Xu
> Priority: Major
> Labels: pull-request-available
>
> See the details from RFC doc
> https://cwiki.apache.org/confluence/display/HUDI/RFC+-+31%3A+Hive+integration+Improvment
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
